Simplify Service Discovery by decoupling the service registry from intent brokering #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladatz
force-pushed
the
feature/servicediscovery
branch
from
6a920c7
to
4e49efe
Compare
liviuft
reviewed
Jun 22, 2023
liviuft
reviewed
Jun 22, 2023
liviuft
reviewed
Jun 22, 2023
liviuft
reviewed
Jun 22, 2023
liviuft
reviewed
Jun 22, 2023
jorchiu
reviewed
Jun 22, 2023
service_discovery/samples/simple-discovery/provider/src/main.rs
Outdated
Show resolved
Hide resolved
liviuft
reviewed
Jun 22, 2023
liviuft
reviewed
Jun 22, 2023
liviuft
reviewed
Jun 22, 2023
liviuft
reviewed
Jun 22, 2023
liviuft
reviewed
Jun 22, 2023
jorchiu
reviewed
Jun 22, 2023
wilyle
reviewed
Jun 22, 2023
jorchiu
reviewed
Jun 22, 2023
liviuft
reviewed
Jun 22, 2023
devkelley
reviewed
Jun 22, 2023
ashbeitz
reviewed
Jun 22, 2023
service_discovery/samples/simple-discovery/consumer/src/main.rs
Outdated
Show resolved
Hide resolved
service_discovery/samples/simple-discovery/consumer/src/main.rs
Outdated
Show resolved
Hide resolved
service_discovery/samples/simple-discovery/provider/src/main.rs
Outdated
Show resolved
Hide resolved
jorchiu
reviewed
Jun 24, 2023
sealemar
reviewed
Jun 26, 2023
service_discovery/samples/simple-discovery/consumer/src/main.rs
Outdated
Show resolved
Hide resolved
jorchiu
approved these changes
Jun 28, 2023
liviuft
reviewed
Jun 28, 2023
liviuft
reviewed
Jun 28, 2023
sealemar
reviewed
Jun 28, 2023
sealemar
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134
Motivation and Context
Today, Service Discovery and intent brokering are tightly coupled. Separating them allows simplification of providers. With this change, providers will only need to communicate with Chariott through clients, rather than needing to implement a specific gRPC interface. This enables simpler execution of the direct application-application communication model. We've received feedback from the community that people using Chariott for Service Discovery would prefer this simpler approach.
Description
Created a new service registry implementation which is completely separate from the intent brokering. This is the first iteration of the new registry, and features will be added over time, according to priority and community feedback.